-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS S3 getconnectionschema handle empty table folders #2818
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
==========================================
- Coverage 36.01% 35.99% -0.02%
==========================================
Files 295 295
Lines 28037 28041 +4
==========================================
- Hits 10098 10094 -4
- Misses 16574 16579 +5
- Partials 1365 1368 +3 ☔ View full report in Codecov by Sentry. |
@@ -627,7 +627,7 @@ func (s *Service) GetConnectionSchema( | |||
return nil, err | |||
} | |||
if out == nil { | |||
break | |||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should add a nice log statement here ? It might be nice if it's an edge case.
@@ -637,6 +637,9 @@ func (s *Service) GetConnectionSchema( | |||
if err != nil { | |||
return nil, err | |||
} | |||
if result.ContentLength == nil || *result.ContentLength == 0 { | |||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, is it worth adding a log statement here? It might be helpful for debugging if this is an edge case.
No description provided.