AWS S3 getconnectionschema handle empty table folders #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
==========================================
- Coverage 36.01% 35.99% -0.02%
==========================================
Files 295 295
Lines 28037 28041 +4
==========================================
- Hits 10098 10094 -4
- Misses 16574 16579 +5
- Partials 1365 1368 +3 ☔ View full report in Codecov by Sentry. |
nickzelei
requested changes
Oct 16, 2024
| @@ -627,7 +627,7 @@ func (s *Service) GetConnectionSchema( | |||
| return nil, err | |||
| } | |||
| if out == nil { | |||
| break | |||
| continue | |||
There was a problem hiding this comment.
maybe we should add a nice log statement here ? It might be nice if it's an edge case.
| @@ -637,6 +637,9 @@ func (s *Service) GetConnectionSchema( | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| if result.ContentLength == nil || *result.ContentLength == 0 { | |||
| continue | |||
There was a problem hiding this comment.
Same, is it worth adding a log statement here? It might be helpful for debugging if this is an edge case.
nickzelei
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.