-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEOS-1565: Refactors CLI to share DB Connection Pools #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickzelei
commented
Oct 23, 2024
•
edited
Loading
edited
- Updates CLI to use more packages that the async workflow does
- For now, hard codes the connection pool limit to 25 until we expose the ability to configure this to users
- Removes direct uses of charm logger in favor of using the slog.Logger. Configures the slog.Logger to use the charm logger underneath.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2844 +/- ##
==========================================
- Coverage 37.39% 37.31% -0.09%
==========================================
Files 297 297
Lines 34741 34814 +73
==========================================
- Hits 12992 12990 -2
- Misses 20207 20285 +78
+ Partials 1542 1539 -3 ☔ View full report in Codecov by Sentry. |
nickzelei
changed the title
refactoring CLI to use connection tunnel manager
Refactors CLI to share DB Connection Pools
Oct 23, 2024
nickzelei
changed the title
Refactors CLI to share DB Connection Pools
NEOS-1565: Refactors CLI to share DB Connection Pools
Oct 23, 2024
alishakawaguchi
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.