Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1565: Refactors CLI to share DB Connection Pools #2844

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Oct 23, 2024

  • Updates CLI to use more packages that the async workflow does
  • For now, hard codes the connection pool limit to 25 until we expose the ability to configure this to users
  • Removes direct uses of charm logger in favor of using the slog.Logger. Configures the slog.Logger to use the charm logger underneath.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 11:01pm

@nickzelei nickzelei added the Tech Debt Created by Linear-GitHub Sync label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 5.15464% with 184 lines in your changes missing coverage. Please review.

Project coverage is 37.31%. Comparing base (82f237a) to head (59d5715).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cli/internal/cmds/neosync/sync/sync.go 0.59% 168 Missing ⚠️
cli/internal/cmds/neosync/sync/ui.go 0.00% 15 Missing ⚠️
...el-manager/pool/providers/sql/sql-pool-provider.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
- Coverage   37.39%   37.31%   -0.09%     
==========================================
  Files         297      297              
  Lines       34741    34814      +73     
==========================================
- Hits        12992    12990       -2     
- Misses      20207    20285      +78     
+ Partials     1542     1539       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei marked this pull request as ready for review October 23, 2024 23:09
@nickzelei nickzelei changed the title refactoring CLI to use connection tunnel manager Refactors CLI to share DB Connection Pools Oct 23, 2024
@nickzelei nickzelei changed the title Refactors CLI to share DB Connection Pools NEOS-1565: Refactors CLI to share DB Connection Pools Oct 23, 2024
Copy link

linear bot commented Oct 23, 2024

@nickzelei nickzelei merged commit 23637d2 into main Oct 23, 2024
8 of 10 checks passed
@nickzelei nickzelei deleted the nick/consolidate-cli-dbpools branch October 23, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech Debt Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants