Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1568: simplifies rdbms url handling #2855

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link

linear bot commented Oct 24, 2024

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:21pm

@nickzelei nickzelei added the bug Something isn't working label Oct 24, 2024
@nickzelei nickzelei marked this pull request as ready for review October 24, 2024 20:19
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 71.53285% with 39 lines in your changes missing coverage. Please review.

Project coverage is 30.19%. Comparing base (488b3f6) to head (10a2200).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
backend/pkg/dbconnect-config/postgres.go 74.54% 14 Missing ⚠️
...ces/mgmt/v1alpha1/connection-service/connection.go 0.00% 14 Missing ⚠️
backend/pkg/dbconnect-config/mysql.go 81.81% 9 Missing and 1 partial ⚠️
backend/pkg/sqlconnect/sql-connector.go 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (488b3f6) and HEAD (10a2200). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (488b3f6) HEAD (10a2200)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2855      +/-   ##
==========================================
- Coverage   38.74%   30.19%   -8.56%     
==========================================
  Files         297      296       -1     
  Lines       34784    34672     -112     
==========================================
- Hits        13478    10468    -3010     
- Misses      19671    23039    +3368     
+ Partials     1635     1165     -470     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit 94dfbe0 into main Oct 24, 2024
12 of 14 checks passed
@nickzelei nickzelei deleted the nick/neos-1568-remove-mysql-uri-limitation branch October 24, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants