NEOS-1567: fixes nil pointer error in cli sync #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
nickzelei
commented
Oct 24, 2024
| c.logger.Info("No tables found.") | ||
| return nil, nil | ||
| c.logger.Warn("no tables found after retrieving connection schema.") | ||
| return &schemaConfig{}, nil |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
==========================================
+ Coverage 39.09% 39.10% +0.01%
==========================================
Files 303 303
Lines 35315 35315
==========================================
+ Hits 13806 13811 +5
+ Misses 19841 19839 -2
+ Partials 1668 1665 -3 ☔ View full report in Codecov by Sentry. |
alishakawaguchi
approved these changes
Oct 24, 2024
nickzelei
deleted the
nick/neos-1567-s3-db-nil-pointer-error-with-empty-tables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.