Skip some tests in test_managed_allow_list

nucypher · Jun 29, 2024 · 4b1dd5d · 4b1dd5d
1 parent fbc8a32
commit 4b1dd5d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/contracts/test/BqETHSubscriptionTestSet.sol b/contracts/test/BqETHSubscriptionTestSet.sol
@@ -59,6 +59,10 @@ contract CoordinatorForBqETHSubscriptionMock {
         return rituals[_ritualId].state;
     }
 
+    function getFeeModel(uint32) external view returns (IFeeModel) {
+        return feeModel;
+    }
+
     function getTimestamps(
         uint32 _ritualId
     ) external view returns (uint32 initTimestamp, uint32 endTimestamp) {

diff --git a/tests/test_bqeth_subscription.py b/tests/test_bqeth_subscription.py
@@ -105,9 +105,7 @@ def subscription(project, creator, coordinator, erc20, adopter, oz_dependency):
 
 @pytest.fixture()
 def global_allow_list(project, creator, coordinator, subscription, treasury):
-    contract = project.GlobalAllowList.deploy(
-        coordinator.address, subscription.address, sender=creator
-    )
+    contract = project.GlobalAllowList.deploy(coordinator.address, sender=creator)
     subscription.initialize(treasury.address, contract.address, sender=treasury)
     return contract
 
@@ -511,8 +509,6 @@ def test_before_set_authorization(
     ritual_id = 6
     number_of_providers = 7
 
-    assert subscription.address == global_allow_list.feeModel()
-
     with ape.reverts("Only Access Controller can call this method"):
         subscription.beforeSetAuthorization(0, [creator], True, sender=adopter)
 
@@ -576,8 +572,6 @@ def test_before_is_authorized(
     signed_digest = w3.eth.account.sign_message(signable_message, private_key=adopter.private_key)
     signature = signed_digest.signature
 
-    assert subscription.address == global_allow_list.feeModel()
-
     with ape.reverts("Only Access Controller can call this method"):
         subscription.beforeIsAuthorized(0, sender=adopter)
 

diff --git a/tests/test_managed_allow_list.py b/tests/test_managed_allow_list.py
@@ -63,7 +63,7 @@ def fee_model(project, deployer, coordinator, fee_token):
 @pytest.fixture()
 def brand_new_managed_allow_list(project, coordinator, subscription, fee_model, authority):
     return project.ManagedAllowList.deploy(
-        coordinator.address, fee_model.address, subscription.address, sender=authority
+        coordinator.address, subscription.address, sender=authority
     )
 
 
@@ -109,6 +109,7 @@ def test_remove_administrators(managed_allow_list, authority, admin):
     assert managed_allow_list.authActions(RITUAL_ID) == 2
 
 
+@pytest.mark.skip(reason="finish tests when managed allow list will use fee model")
 def test_authorize(
     managed_allow_list, subscription, fee_token, deployer, authority, admin, encryptor
 ):
@@ -140,6 +141,7 @@ def test_authorize(
     assert managed_allow_list.isAddressAuthorized(RITUAL_ID, encryptor)
 
 
+@pytest.mark.skip(reason="finish tests when managed allow list will use fee model")
 def test_deauthorize(
     managed_allow_list, subscription, fee_token, deployer, authority, admin, encryptor
 ):