Minor fixes: perform strip() on provider addresses from file, print number of missing transcripts/aggregations during ritual_state_check
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esses file. Fix linter errors.
derekpierre
requested review from
KPrasch,
cygnusv,
theref,
vzotova and
manumonti
derekpierre
changed the title
ritual_state_check
cygnusv
reviewed
Sep 4, 2024
| @@ -83,7 +83,7 @@ def cli( | |||
| num_nodes, | |||
| random_seed, | |||
| handpicked, | |||
| min_version | |||
| min_version, | |||
There was a problem hiding this comment.
Shouldn't the trailing comma be the default linting?
There was a problem hiding this comment.
Indeed, it should be - it was missed previously for some reason.
There was a problem hiding this comment.
Oh I don't know why I interpreted the diff the other way around. Disregard...
KPrasch
approved these changes
Sep 4, 2024
cygnusv
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
ritual_state_checkfor showing number of missing transcripts/aggregations.Issues fixed/closed:
Why it's needed:
Notes for reviewers: