Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coordinator Alpha 12 #92

Merged
merged 83 commits into from
Aug 28, 2023
Merged

Coordinator Alpha 12 #92

merged 83 commits into from
Aug 28, 2023

Conversation

KPrasch
Copy link
Member

@KPrasch KPrasch commented Jun 26, 2023 •
edited
Loading

No description provided.

cygnusv and others added 20 commits June 9, 2023 08:04
@cygnusv
Introduce duration parameter for ritual creation
41f1634 
Optimize Ritual struct layout
@cygnusv
Introduce Initiator role to gatekeep ritual initiation
e56c3ef 
Also replace contract owner for parameter administration role
@cygnusv
Add authority field to Ritual. Can be different than initiator
f24fd29 
Initiator is just the entity that calls initiateRitual(), needs to be authorized, and provides initial payment.
Authority is who controls ritual lifecycle going forward.
@cygnusv
Introduce interface for Fee Models
deb7fcf 
Fee Models dictate what's the cost for rituals
@cygnusv
Basic FlateRateFeeModel
b8492bf
@cygnusv
EndRitual event only needs to track ritualID and the outcome
7ccae5b
@cygnusv
Use DEFAULT_ADMIN_ROLE as parameters admin
66e1f64 
Also, changes AccessControl base contract for the more specific AccessControlDefaultAdminRules
@cygnusv
Function to make initiation public (no initiator allowlist)
64792c1 
Also, change isInitiationRegulated to isInitiationPublic
@cygnusv
Introduce feeModel parameter and use it to charge the proper ritual cost
d13d287
@cygnusv
Automatic reimbursing of ritual costs via ReimbursementPool
ddb0847 
See https://github.com/keep-network/keep-core/blame/main/solidity/random-beacon/contracts/ReimbursementPool.sol
@cygnusv
Assorted fixes
f11e8c4 
Can't revoke INITIATOR_ROLE addresses since our AccessControl doesn't inherit from AccessControlEnumerable. It doesn't matter much anyway
@cygnusv
Bump OZ dependency to v4.9.1
486b893
@cygnusv
Make transcript size a test constant
cf9e74a 
We may want to parametrize tests based on this
@cygnusv
Deployment script for FlatRateFeeModel
55fa421
@cygnusv
Add DAI deployment address for Polygon Mainnet and Mumbai
a896ed0 
Add also previous StakeInfo deployment on Mumbai
@cygnusv
Add stakes reference to Fee Model contracts
85cc9c2
@cygnusv
Single finalization logic when posting aggregations
d634394
@cygnusv
Treat fees as pending until ritual is final
02b93ed 
Either ritual is successful and fees can be used by the protocol, or ritual is failed and fees are refunded to initiator (consider partial refund)
@derekpierre @cygnusv
Ensure that provided decryption request static key by nodes is 42 byt…
f819fac 
…es long (as of nucypher-core v0.10.0).
@cygnusv
Adapt Coordinator tests to latest additions
bc11d12
@KPrasch KPrasch changed the title [WIP] Threshold access control application [WIP] Threshold access control application contracts Jun 26, 2023
@KPrasch KPrasch changed the title [WIP] Threshold access control application contracts [WIP] Coordinator Alpha 8 Jul 12, 2023
@KPrasch KPrasch changed the title [WIP] Coordinator Alpha 8 [WIP] Coordinator Alpha 9 Aug 22, 2023
@KPrasch KPrasch changed the title [WIP] Coordinator Alpha 9 [WIP] Coordinator Alpha 11 Aug 24, 2023
@KPrasch KPrasch mentioned this pull request Aug 24, 2023
Closed
KPrasch and others added 17 commits August 24, 2023 15:29
@KPrasch
Merge pull request #109 from vzotova/impr
3f9d0cc 
General repo improvements
@cygnusv
API for bidirectional mapping between public keys and successful rituals
8d2d327
@cygnusv
Invalidate stored public key if ritual fails
b7f04c2 
Closes #78
@cygnusv
Store threshold in ritual struct, but not allow initiator to set it f…
5f81380 
…or the moment

We currently define it as the lowest value that produces a threshold set that's strictly greater than the 50% of the overall size.
See nucypher/nucypher#3095
@cygnusv
Define minimum ritual duration as 24 hours.
57cfa1c 
See #106
@cygnusv
Additional tests for coordinator
675219d
@cygnusv
It's FlatRate, not FlateRate....
c4848ae
@cygnusv
Simplify deployment by Coordinator extending from FlatRateFeeModel
6f3d2d2 
We can revert to a composition model later, but for the moment this will make our lives easier
@cygnusv
Further simplify FeeModel contracts since Coordinator now extends them
dae568a
@cygnusv
Adapt tests to new FeeModel situation
168c8ca
@cygnusv
Pass raw signature input when checking encryption authorization, inst…
3e52784 
…ead of hash
@cygnusv
Optimize lookup mapping in GlobalAllowList
ff0fee6 
Closes #97
@cygnusv
Further checks when setting Coordinator in AllowList contracts
d05d202
@cygnusv
Define TREASURY_ROLE to manage DKG fees
7de9a24
@cygnusv
Change fee refund approach to everything minus cost for a day
76c1af5
@cygnusv
Remove outdated TODOs
e36477f
@cygnusv
Solhint changes
2263b47
@KPrasch KPrasch changed the title [WIP] Coordinator Alpha 11 [WIP] Coordinator Alpha 12 Aug 26, 2023
@KPrasch
Merge pull request #107 from cygnusv/chachachanges
af4433b 
Yet another batch of improvements for Coordinator
@KPrasch KPrasch changed the title [WIP] Coordinator Alpha 12 Coordinator Alpha 12 Aug 28, 2023
@KPrasch KPrasch marked this pull request as ready for review August 28, 2023 11:03
@KPrasch KPrasch merged commit 95de44f into main Aug 28, 2023
4 checks passed
@KPrasch KPrasch mentioned this pull request Aug 28, 2023
Merged
This was referenced Aug 31, 2023
Merged
Merged
@derekpierre derekpierre mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KPrasch @cygnusv @derekpierre @piotr-roslaniec @vzotova