Respect attribute translations in #check_box

[atipugin]

Solves this issue: https://github.com/Fullscreen/bh/issues/123

[coveralls]

Coverage decreased (-29.74%) to 70.26% when pulling 66303f1 on atipugin:master into 98e0743 on Fullscreen:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 2dfd42a on atipugin:master into 98e0743 on Fullscreen:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 14969fe on atipugin:master into 98e0743 on Fullscreen:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 7ed8532 on atipugin:master into 98e0743 on Fullscreen:master.

[claudiofullscreen]

Thanks for your work @atipugin ! I'll look into this human_attribute_name method a little (because I don't know it) before accepting.

Meanwhile, do you mind changing the syntax of this method? I don't like return … if … statements.
You could just write the following instead:

def default_label_for(method)
  if object.class.respond_to? :human_attribute_name
    object.class.human_attribute_name method
  else
    method.to_s.humanize
  end
end

Apart from that, I want to make check whether:

• "default" is a good name for this method default_label_for. What is your rationale behind this name?
• the code will work if human_attribute_name is defined, but then no translation exists for the method

Thanks again, everything else looks good!!!

[claudiofullscreen]

Could you also squish all your commits together? Thanks! 🎀

[atipugin]

Changed code to if/else statement. Answering your questions:

1. "#default" is too ambiguous for this. Module itself handles whole checkbox, not only a label's text.
2. Code will work. #human_attribute_names uses same #humanize as fallback for absent translations.

[coveralls]

Coverage decreased (-0.05%) to 99.95% when pulling b758a6a on atipugin:master into 98e0743 on Fullscreen:master.

[coveralls]

Coverage decreased (-0.05%) to 99.95% when pulling f10011d on atipugin:master into 98e0743 on Fullscreen:master.

[koenpunt]

Ping! 🌟