-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ios/feature/create swift package #1
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0fed472
-changed dependecy for swift macrotester to https url
dani-hengl 286c504
- uncommented lines in Package file
dani-hengl 5bf4b6b
-fixed import for swift-macrotester
dani-hengl 43ba167
-changed import after renming macrotester back to MacroTester
dani-hengl 96bb571
- adjustments after renaming MacroTester
dani-hengl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /.swiftpm | ||
| /Package.resolved |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ let package = Package( | |
| ) | ||
| ], | ||
| dependencies: [ | ||
| .package(path: "../MacroTester"), | ||
| .package(url: "[email protected]:num42/swift-macrotester.git", from: "1.0.0"), | ||
| // Depend on the Swift 5.9 release of SwiftSyntax | ||
| .package(url: "https://github.com/apple/swift-syntax.git", from: "509.0.0"), | ||
| .package( | ||
|
|
@@ -36,33 +36,31 @@ let package = Package( | |
| dependencies: [ | ||
| .product(name: "SwiftSyntaxMacros", package: "swift-syntax"), | ||
| .product(name: "SwiftCompilerPlugin", package: "swift-syntax") | ||
| ] | ||
| // plugins: [.plugin(name: "SwiftLintPlugin", package: "SwiftLint")] | ||
| ], | ||
| plugins: [.plugin(name: "SwiftLintPlugin", package: "SwiftLint")] | ||
| ), | ||
|
|
||
| // Library that exposes a macro as part of its API, which is used in client programs. | ||
| .target( | ||
| name: "Changeable", | ||
| dependencies: ["ChangeableMacros"] | ||
| // plugins: [.plugin(name: "SwiftLintPlugin", package: "SwiftLint")] | ||
| dependencies: ["ChangeableMacros"], | ||
| plugins: [.plugin(name: "SwiftLintPlugin", package: "SwiftLint")] | ||
| ), | ||
|
|
||
| // A client of the library, which is able to use the macro in its own code. | ||
| .executableTarget( | ||
| name: "ChangeableClient", | ||
| dependencies: ["Changeable"] | ||
| // plugins: [.plugin(name: "SwiftLintPlugin", package: "SwiftLint")] | ||
| ) | ||
|
|
||
| dependencies: ["Changeable"], | ||
| plugins: [.plugin(name: "SwiftLintPlugin", package: "SwiftLint")] | ||
| ), | ||
| // A test target used to develop the macro implementation. | ||
| // .testTarget( | ||
| // name: "ChangeableTests", | ||
| // dependencies: [ | ||
| // "ChangeableMacros", | ||
| // .product(name: "MacroTester", package: "MacroTester"), | ||
| // .product(name: "SwiftSyntaxMacrosTestSupport", package: "swift-syntax") | ||
| // ] | ||
| // plugins: [.plugin(name: "SwiftLintPlugin", package: "SwiftLint")] | ||
| // ) | ||
| .testTarget( | ||
| name: "ChangeableTests", | ||
| dependencies: ["ChangeableMacros", | ||
| .product(name: "MacroTester", package: "swift-macrotester"), | ||
| .product(name: "SwiftSyntaxMacrosTestSupport", package: "swift-syntax") | ||
| ], | ||
| plugins: [.plugin(name: "SwiftLintPlugin", package: "SwiftLint")] | ||
| ) | ||
| ] | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this elongated the build a lot, will not be a problem when we use the "macros via mint" solution but might increase build time at first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(so: leave it as it is now, just a heads-up comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still need support on that, i managed to include it in Mint but was not able to successfully reference it inside the classes (implementation was not found)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I documented my knowledge in #3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ok will address this inside the issue for migrating to Mint