-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all refops if a basic block is a raising block #1045
Open
dlee992
wants to merge
12
commits into
numba:main
Choose a base branch
from
dlee992:fix_1044
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlee992
changed the title
skip
move Apr 29, 2024
hasDecrefInNode
and hasAnyDecrefInNode
if it's a raise
blockisRaising
check ahead before hasDecref
check in refprune
dlee992
changed the title
move
remove all refops if a basic block is a raising block
Apr 30, 2024
isRaising
check ahead before hasDecref
check in refprune
Hi, @sklam. This is another small improvement for ref-pruning. It can enjoy your review! Thanks |
Hi, any comment for this PR and the related issue? cc @esc |
@dlee992 I suppose this ought to make |
Yeah, I will make up one test case for it ASAP (probably tmr). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible way to
fix #1044
Notes for reviewers: