-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statically link compiler-rt #976
Conversation
Hi @oliverhu - many thanks for the PR continuing this work! We'll discuss assigning it at the triage meeting tomorrow. |
From the discussion in Gitter and in the triage meeting, the path forward to the review / testing / merge of this looks like:
@oliverhu Does this plan make sense to you, and would you be happy to go ahead with splittling out the |
Sounds good. |
I'm uploading packages to the gmarkall account on anaconda.org: https://anaconda.org/gmarkall/llvmdev/files To proceed with this PR:
The above are the items that I can see on first glance - hopefully we can have another iteration after looking at the above which will be a little simpler! Many thanks again for your efforts here! |
Closing this one, we can follow up in #986 |
This PR addesses issues in #834 and tinygrad/tinygrad#1367, in which
libllvmlite.so
fails to resolve symbols inlibclang_rt.builtin.a
since compiler rt is not linked. This PR statically links the compiler_rt library.This PR is based on top of #909 from @testhound
Validated both cmake & Makefile work on Ubuntu.
I did not test in Windows