Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patching debug logging calls and debug print statements #92

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Patching debug logging calls and debug print statements #92

merged 2 commits into from
Aug 8, 2023

Conversation

kc611
Copy link
Contributor

@kc611 kc611 commented Aug 8, 2023

As titled,

This PR patches all calls to logging.basicConfig and orphan print statements used for debugging purposes.

sklam
sklam approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've tested this patch against numba/numba#9012.

@esc
Copy link
Member

esc commented Aug 8, 2023

@kc611 thank you for the patch! @sklam thank you for the review!

@esc esc merged commit 85d4c7c into numba:release_0.0.3 Aug 8, 2023
1 check passed
esc added a commit to esc/numba-rvsdg that referenced this pull request Aug 9, 2023
@esc
Merge pull request numba#92 from kc611/debug_patch
800931d 
Patching debug logging calls and debug print statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklam sklam sklam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kc611 @esc @sklam