Skip to content

Commit

Permalink
Merge pull request #2469 from numbersprotocol/release-0.72.4
Browse files Browse the repository at this point in the history
Release 0.72.4
  • Loading branch information
bafu authored Jan 10, 2023
2 parents 732dcc5 + 89a911a commit 5aad1be
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 20 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

To check the difference between the last releaes and the latest dev status, click the link above.

## [0.72.4] - 2023-01-10

### Fixed

1. Force set QR code text to white in Transfer page (#2466)

## [0.72.3] - 2023-01-06

### Fixed
Expand Down Expand Up @@ -2001,7 +2007,8 @@ This is the first release! _Capture Lite_ is a cross-platform app adapted from [
- Web - see the demo [here](https://github.com/numbersprotocol/capture-lite#demo-app)
- Android - the APK file `app-debug.apk` is attached to this release

[unreleased]: https://github.com/numbersprotocol/capture-lite/compare/0.72.3...HEAD
[unreleased]: https://github.com/numbersprotocol/capture-lite/compare/0.72.4...HEAD
[0.72.4]: https://github.com/numbersprotocol/capture-lite/compare/0.72.3...0.72.4
[0.72.3]: https://github.com/numbersprotocol/capture-lite/compare/0.72.2...0.72.3
[0.72.2]: https://github.com/numbersprotocol/capture-lite/compare/0.72.1...0.72.2
[0.72.1]: https://github.com/numbersprotocol/capture-lite/compare/0.72.0...0.72.1
Expand Down
19 changes: 7 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ npm run build.android

### Release

See the [Capture App release flow (Miro)](https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764542656055086&cot=14).

Some nodes below:

Bump version in `package.json`.

```json
Expand All @@ -124,7 +128,7 @@ Bump version in `android/app/build.gradle`.
```gradle
android {
defaultConfig {
versionCode <versionCode += a_diff*100 + b_diff*10 + c_diff>
versionCode <versionCode++>
versionName "a.b.c"
}
}
Expand All @@ -134,17 +138,8 @@ Run `npm i` to update `package-lock.json`.

Write the changelog in `CHANGELOG.md`.

When push to the `master` branch with new version in the `package.json` file, GitHub Action would automatically do the following jobs:
When push to the `master` branch with new version tag, GitHub Action would automatically do the following jobs:

1. Create release GitHub page with debug APK.
1. Publish the app to Play Console on alpha track.
1. Upload debug apk to Google Drive.
1. Publish the app to Play Console on alpha track and Apple Store.
1. Send notification to the private `reminder-releases` slack channel.

If error occur in `deploy-app-store` GitHub Action, most likely it's due to some weird error with GitHub MacOS runner or iOS server. Re-run the failed job should fix that. However, you might run into

```
Error: Validation Failed: {"resource":"Release","code":"already_exists","field":"tag_name"}
```

In this case, you could delete the releae tag by doing `git push --delete origin tagname`. E.g. `git push --delete origin 0.53.0`.
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ android {
applicationId "io.numbersprotocol.capturelite"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 462
versionName "0.72.3"
versionCode 463
versionName "0.72.4"
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
buildFeatures {
Expand Down
4 changes: 2 additions & 2 deletions ios/App/App.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@
INFOPLIST_FILE = App/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MARKETING_VERSION = 0.72.3;
MARKETING_VERSION = 0.72.4;
OTHER_SWIFT_FLAGS = "$(inherited) \"-D\" \"COCOAPODS\" \"-DDEBUG\"";
PRODUCT_BUNDLE_IDENTIFIER = io.numbersprotocol.capturelite;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -401,7 +401,7 @@
INFOPLIST_FILE = App/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MARKETING_VERSION = 0.72.3;
MARKETING_VERSION = 0.72.4;
PRODUCT_BUNDLE_IDENTIFIER = io.numbersprotocol.capturelite;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = NumbersAppDistributionV4;
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "capture-lite",
"version": "0.72.3",
"version": "0.72.4",
"author": "numbersprotocol",
"homepage": "https://numbersprotocol.io/",
"scripts": {
Expand Down
1 change: 1 addition & 0 deletions src/app/features/wallets/transfer/transfer.page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ ion-card {
display: flex;
flex-direction: column;
align-items: center;
color: white !important; /* stylelint-disable-line declaration-no-important */
}

.qr-code-info {
Expand Down

0 comments on commit 5aad1be

Please sign in to comment.