Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "medium string" mode where the sizes of arena allocations are stored using a
char
instead of asize_t
, saving 8 bytes per string for strings with lengths between 16 and 255 bytes. I modified the tests so they use longer strings more often which exercises all the different memory allocation modes we're now supporting.I also dropped the attempt to store the
size_t
sizes in aligned locations because it adds a bunch of bookkeeping headaches. If it turns out thememcpy
to unaligned addresses is slow we can come back to this.