Updates to match the NEP #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seberg in the last few commits I refactored it so The only slightly tricky thing is the dtype implementation needs to know the struct size and alignment to set the elsize and alignment, so I defined a macro that handles that. The macro and the layout just need to be kept in sync if they're ever changed. |
|
OK, this now fully matches what I have in the latest version of the NEP. Pulling this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly cosmetic changes to match some of the naming I arrived at in the NEP. I also fixed a reference counting issue in
stringdtype_setitemthat caused a memory leak I hadn't noticed until now.I also updated the README. @rgommers is there any chance you can try this out in a fresh python environment and let me know if you run into issues? I'd like to include a call for testing the dtype in my message to the numpy mailing list about the NEP updates.