Update for numpy 2.0 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Thanks for looking into this! Just scrolled through and looks fine. I didn't understand why you added that numpy return, but I may have missed it elsewhere.
I guess for the string dtype deleting tests where NumPy changed makes sense (and is fine with me either way).
Please don't hesitate to just self merge when you got the tests passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this all the dtypes build and the tests pass on current numpy dev. Let's see what the CI says.
ping @seberg in case you want to look this over.