In TestAssemblyResolver the DependencyContext can be null

nunit · Dec 31, 2024 · 2667029 · 2667029
1 parent b18b1ee
commit 2667029
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/NUnitEngine/nunit.engine.core/Internal/TestAssemblyResolver.cs b/src/NUnitEngine/nunit.engine.core/Internal/TestAssemblyResolver.cs
@@ -152,12 +152,12 @@ bool FileMatchesAssembly(string fileName) =>
 
         public class RuntimeLibrariesStrategy : ResolutionStrategy
         {
-            private DependencyContext _dependencyContext;
+            private DependencyContext? _dependencyContext;
             private readonly ICompilationAssemblyResolver _assemblyResolver;
 
             public RuntimeLibrariesStrategy(AssemblyLoadContext loadContext, string testAssemblyPath)
             {
-                _dependencyContext = DependencyContext.Load(loadContext.LoadFromAssemblyPath(testAssemblyPath)).ShouldNotBeNull();
+                _dependencyContext = DependencyContext.Load(loadContext.LoadFromAssemblyPath(testAssemblyPath));
 
                 _assemblyResolver = new CompositeCompilationAssemblyResolver(new ICompilationAssemblyResolver[]
                 {
@@ -170,6 +170,13 @@ public RuntimeLibrariesStrategy(AssemblyLoadContext loadContext, string testAsse
             public override bool TryToResolve(
                 AssemblyLoadContext loadContext, AssemblyName assemblyName, [NotNullWhen(true)] out Assembly? loadedAssembly)
             {
+                if (_dependencyContext == null)
+                {
+                    // TODO: Is this the intended behavior?
+                    loadedAssembly = null;
+                    return false;
+                }
+
                 foreach (var library in _dependencyContext.RuntimeLibraries)
                 {
                     var wrapper = new CompilationLibrary(