-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T2A2][T11-A3]Tyler Rocha #137
base: master
Are you sure you want to change the base?
Conversation
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on the activity. Try to make use of eclipse shortcuts to help you with the indentations. You would have to switch from tabs to spaces in the eclipse settings though.
case 1: | ||
setupGivenFileForStorage(args[0]); | ||
break; | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good refactoring here. However, indentation is off. Our standard requires 4 spaces.
Hi @tylerrocha, your pull request title is invalid. It should be in the format of Submit only one activity per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR. |
No description provided.