Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[T2A3][T11-A3]Tyler Rocha #138

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[T2A3][T11-A3]Tyler Rocha #138

wants to merge 4 commits into from

Conversation

tylerrocha
Copy link

No description provided.

@tylerrocha
Copy link
Author

Ready for review

ZawadulFarhan
ZawadulFarhan reviewed Jan 29, 2017
View reviewed changes
Copy link

@ZawadulFarhan ZawadulFarhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this activity helps you understand why the SLAP principle is important.

src/seedu/addressbook/AddressBook.java
*/
private static void processProgramArgs(String[] args) {
if (args.length >= 2) {
showToUser("===================================================", "===================================================", VERSION, MESSAGE_WELCOME, "===================================================");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines end up being excessively long. You could look into writing multiple lines in the coding standard document.

@nus-se-pr-bot
Copy link

Hi @tylerrocha, your pull request title is invalid. It should be in the format of [Activity ID][Team ID] Your name, where [Activity Id] has no dashes or spaces (e.g. [T2A3] stands for Tutorial 2 Activity 3) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2). Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one activity per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

@tylerrocha tylerrocha changed the title [T2A3][T11-]Tyler Rocha [T2A3][T11-A3]Tyler Rocha Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZawadulFarhan ZawadulFarhan ZawadulFarhan left review comments

Assignees

@ZawadulFarhan ZawadulFarhan

Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylerrocha @nus-se-pr-bot @ZawadulFarhan @mauris