Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file path #181

Open
wants to merge 158 commits into
base: master
Choose a base branch
from

Conversation

zhypaul
Copy link

@zhypaul zhypaul commented Mar 30, 2017

added command to Change storage location as user specifies.

@nus-se-pr-bot
Copy link

Hi @zhypaul, your pull request title is invalid. It should be in the format of [Activity ID][Team ID] Your name, where [Activity Id] has no dashes or spaces (e.g. [T2A3] stands for Tutorial 2 Activity 3) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2). Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one activity per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

@4mirai 4mirai deleted the ChangeFilePath branch April 7, 2017 00:27
Megan-Quek referenced this pull request in Megan-Quek/main Apr 9, 2017
…AN2017-T16-B3#181 (CS2103JAN2017-T16-B3#182)

* codestyle: ensure curly brackets are separated by whitespace

The Java coding standard[1] requires that curly brackets ({}) be
surrounded by whitespace.

However, there are several violations of this requirement in the code
base. e.g.

    protected void raise(BaseEvent event){
    -------------------------------------^
                        Space required before '{'

Fix all of these code style violations.

[1] https://oss-generic.github.io/process/codingstandards/coding-standards-java.html#methods

* checkstyle: ensure curly brackets have whitespace around them

There used to be methods in the code base where the curly brackets ({})
are not separated by whitespace:

    protected void raise(BaseEvent event){
    -------------------------------------^
                        Space required before '{'

Our checkstyle configuration failed to catch these errors because we did
not tell checkstyle to check for the LCURLY, RCURLY and SLIST (statement
list) tokens. Fix this in the checkstyle config file so that such code
style violations will not happen again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants