Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-W17-2] LetsGetHired #174

Open
wants to merge 613 commits into
base: master
Choose a base branch
from

Conversation

tim-pipi
Copy link

@tim-pipi tim-pipi commented Oct 3, 2023

LetsGetHired is a desktop app which provides a fast and organised way to see internships and its progress,
optimised for users who prefer a Command Line Interface (CLI) while still having the benefits of a Graphical User Interface (GUI).

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 200 lines in your changes are missing coverage. Please review.

Comparison is base (517b785) 75.26% compared to head (0d458f9) 76.42%.

❗ Current head 0d458f9 differs from pull request most recent head 2485917. Consider uploading reports for the commit 2485917 to get more accurate results

Files Patch % Lines
...du/letsgethired/ui/InternApplicationListPanel.java 0.00% 35 Missing ⚠️
.../seedu/letsgethired/model/util/SampleDataUtil.java 0.00% 27 Missing ⚠️
...edu/letsgethired/ui/InternApplicationListCard.java 0.00% 25 Missing ⚠️
...rc/main/java/seedu/letsgethired/ui/SelectView.java 0.00% 17 Missing ⚠️
...u/letsgethired/logic/parser/FindCommandParser.java 62.50% 9 Missing and 6 partials ⚠️
src/main/java/seedu/letsgethired/MainApp.java 0.00% 13 Missing ⚠️
...rc/main/java/seedu/letsgethired/ui/MainWindow.java 0.00% 12 Missing ⚠️
...seedu/letsgethired/model/application/Deadline.java 61.53% 10 Missing ⚠️
...ication/CompanyContainsFieldKeywordsPredicate.java 79.06% 3 Missing and 6 partials ⚠️
...model/application/InternApplicationComparator.java 90.90% 5 Missing and 1 partial ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #174      +/-   ##
============================================
+ Coverage     75.26%   76.42%   +1.15%     
- Complexity      419      587     +168     
============================================
  Files            71       84      +13     
  Lines          1338     1866     +528     
  Branches        126      201      +75     
============================================
+ Hits           1007     1426     +419     
- Misses          301      397      +96     
- Partials         30       43      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AprupKale and others added 29 commits November 2, 2023 23:01
Currently, we cannot sort by internship deadline.

Let's add sorting by internship deadline to the existing
sort logic.
Implementing the comparable interface for each
field in the Model will simplify the sorting process.
Add some assertions for methods associated with undo and view.
View command can be done using the GUI as well, by clicking on a specific internship application card.
zsh-eng and others added 30 commits November 13, 2023 12:01
Add Appendix: Instructions for Manual Testing
Update downloadJar image and Fix Formatting Error
Fix typo errors in You Wei PPP
Fix text formatting in PPP
You Wei PPP bug fixes
Fix broken link in You Wei PPP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants