-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kube refine for backup #793
Conversation
Define the required information in `$env.KUBERNETES_REFINE`, `kube refine` will collect information according to its definition Definitions in `status` and `cluster_status` are runtime information and will not be collected. They are used in the `kg` command to display status A new module, `refine.nu`, declaratively extracts data from complex structures. `container-list` additionally displays the cmd field of the image rename `kcconf` to `kccc` (kubectl change context clone)
- docker volume dump/restore - host-path support volume - container-remove safely - image-list - parse created - fix id - image-select
I'm not a fan of these changes. It's hard to tell what this argx file you're putting in several folders does. There are changes not mentioned in the description. You're creating a new log command when there's already one in the std lib. Lack of comments explaining what the custom commands do. |
The argx file is copied from modules/argx/argx.nu for the purpose of passing the ci test.I'm not sure if the CI test must be passed, and I don't know of any other better methods. Log command can support structured logs in logfmt (not strict), and can output to a file (I'm not sure if std log can).
The latter two are optional. This part was originally written directly as a function in kubernetes.nu. Later, there were too many references, so it was taken out as a separate module. If I follow the original method, I need to copy the kubernetes.nu file and then paste this section, which is too troublesome. I can also remove the part |
Your changes are better but I'm still not a fan of |
`--multiline` control formatting Remove redundant argx.nu
ok, I understand, how about changing it to update: has been changed to |
ok, good enough. do you want to keep working on it or are you done? |
88be461 |
https://github.com/nushell/nu_scripts/actions/runs/8488088746/job/23256669801 |
If this ok, please merge it. Otherwise, I will revert 88be461 . |
ba82366
to
91bd7bc
Compare
The only thing that bothers me is that you renamed git-v2.nu to mod.nu as if your git module owns the changes in that folder. It may be better to make a gitv2 folder to switch to mod.nu so the other files don't get lost. |
Ok, but the file |
new function
kube refine
$env.KUBERNETES_REFINE
,kube refine
will collect information according to its definitionstatus
andcluster_status
are runtime information and will not be collected. They are used in thekg
command to display statuskg
,kgp
,kgs
command usingkrefine
rename
kcconf
tokccc
(kubectl change context clone)a new module,
refine.nu
, declaratively extracts data from complex structures.container-list
additionally displays the cmd field of the image