🐛 parser fixes

[AucaCoyan]

• replace str collect for str join
• replace str lpad for fill
• str lpad -c for fill --width
• str rpad -l for fill --alignment r --width
• updated before_v0.60/README.md
• $nu.scope.commands for scope commands
• add a couple of if (true) {} else {} (else keyword)
• $true for true
• $false for false

[AucaCoyan]

There are a couple of errors in some files, that is because they arent 0.91.1 compliant. I believe it can be merged with no problem

[fdncred]

I don't really get the point of modifying files in the before_v0.60 folder so that they don't work in a different way. Those files work with versions of nushell before 0.60 right now, although I doubt anyone is using those versions. If we change it like you have here, they neither work for versions before 0.60 or after 0.60.

The idea when I created the before_v0.60 folder was that people would move a given script to the appropriate folder in the new folder structure, then update it to work with whatever version they were working on. That would add the new script to the new folders, and remove the script from the old folders. Eventually, there would be no files in the before_v0.60 folder because all the scripts were ported. It hasn't quite worked out like that but that was the idea.

[AucaCoyan]

I see. I'll revert some of those changes and see if I'm capable of moving some scripts to current nushell. I'll be back

[AucaCoyan]

Well, time has passed and the PR still was in the same place I left it. I think it's better to stop here and leave the transcription from 0.60 to present nushell to another day.
One strange thing it came up was that I don't detect the errors the CI is throwing, nor in VS Code or in the terminal

No trouble at all. I'm using the same version 0.92.0.
Do you see anything to correct? Is the CI responding with a false positive or am I missing something?

[fdncred]

if you clean up the conflicts and test it out again we can land this, thanks.

[fdncred]

Thanks!