panache-git: do not print stderr from Git commands

[ehdevries]

Nushell 0.92 changed how external commands operate in pipelines: https://www.nushell.sh/blog/2024-04-02-nushell_0_92_0.html

After updating to Nushell 0.92, panache-git would print errors when the current working directory was not a Git repository: "fatal: not a git repository (or any of the parent directories): .git"

This change properly handles stderr from Git commands according to Nushell's updated external command behavior.

Also, Nushell 0.91 introduced "is-not-empty", so places in the code where a string was checked for being not-empty or not-contains were simplified a bit.

Finally, the main command in the module was renamed to "main" to make it simpler to import and use in config.

[fdncred]

We plan to revisit the topic of do -i in our meeting tomorrow. So, let's hold off on this for the moment. Thanks.

[fdncred]

I've documented this in a couple places. Adding here too.

After discussing this in our team meeting yesterday, our decision was to try and simplify do and get rid of these parameters.

• --ignore-errors/-i
• --ignore-shell-errors/-s
• --ignore-program-errors/-p
• --capture-errors/-c

And replace them with better syntax for handling redirection. There's no ETA yet but that is the desired goal. In the mean time, I'll land the patch for panache-git that fixes the problem we introduced.

We may want to restore the do -i "eat all errors" functionality temporarily too.

[neur1n]

I applied this patch but error messages still get printed. I'm using nushell on Windows 11 and do not have access to a Linux machine currently.

[fdncred]

@neur1n I'm not having any issues with it on MacOS. I just added this to my config.nu.

use "modules/prompt/panache-git.nu" main
$env.PROMPT_COMMAND = { panache-git }

[neur1n]

Sorry, it was my fault. I'm invoking another git command that is not in panache-git, without such a patch.