Port before_v0.60/fun folder (issue #221)
#835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`def "-" [x, y] { $x - $y }` is a valid syntax but apparently function call not working anymore.
another functions work well. I wrap them in "" anyway
`before_v0.60/fun/life.nu` -> `modules/fun/life.nu`
- rename all `-` in variable names to `_`
- replace `nth` with `get`
- replace `$true` and `$false` with `true`, `false`
- add `else` to `if {} {}`
- replace pipeline `for` with `each {|x|...}`
- replace the table `[[width height data]; ...]` with record `{ width:..., height: ..., data:...}` because there is only one record. (old `nu` was making automatic dereference)
- `str collect` with `str join`
- `echo` with `print`
- clear screen with `clear`
- remove unnecessary `char nl`
- remove `main` call at the end
`before_v0.60/fun/nyancat.nu` -> `modules/fun/nyancat.nu`
- fix frames content: strange `and` to '&'
- replace removed `char` subcommands
- make `frames` as a list
- `for -n` and `nth $it.index` -> `for frame in $frames {}`
- just `print` each frame
- `ansi cls` to `clear`
- merge two variants: print each frame at a time - implement missing `atan2` - use std math `$math.PI` - remove `autoview` - fix renamed fields in `(term size)`
already ported to `sourced/fun/spark.nu`
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of porting all old scripts #221 and ports
funfolderSummary
star.nu
spark.nu
The script has already been ported. I've removed old version.
life.nu
lisp_mode.nu
There is a problem with this module because
-is not allowed in names anymore, howeverdef "-"is a valid syntax, but you will be unable to call this function.nyancat.nu
I also fixed animation frames from https://github.com/klange/nyancat