Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sys usage #916

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fixed sys usage #916

merged 1 commit into from
Jul 24, 2024

Conversation

lizclipse
Copy link
Contributor

@lizclipse lizclipse commented Jul 24, 2024

Just as a heads up, I haven't really tested this since a lot of it is stuff I don't use or know how to set up without some reading up. I have tested the nu_conda_2 change since I have a python project that I use that for, and I could look into testing more of it if needed.

I've tried finding (naively using /sys\W/) all the usage of the old plain sys calls and replacing them with alternates as appropriate, which mostly has been to swap a (sys).host.name call into a $nu.os-info.name one, since it'll be tad faster and more consistent across platforms with naming (especially as the value comes from the rust stdlib and is very predictable).

Fixes #897

@lizclipse
Copy link
Contributor Author

That build error is on something I haven't changed and I have no idea why it's not working. The referenced module does exist, but nu seems to be plugging its ears and going 'lalalalala'. Changing to a use, prefixing the path with ./, or removing the .nu suffix all doesn't help.

@fdncred
Copy link
Collaborator

fdncred commented Jul 24, 2024

I'm not worried about the ci. it works about 25% of the time. this one is failing because the script assumes the folder is in NU_LIB_DIRS, which it isn't in CI.

The rest of this looks good. Thanks!

@fdncred fdncred merged commit eedcd10 into nushell:main Jul 24, 2024
1 check failed
@lizclipse lizclipse deleted the fix-sys-usage branch July 24, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong syntax for accessing host name in nu_conda_2/conda.nu
2 participants