Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade range syntax #953

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Upgrade range syntax #953

merged 1 commit into from
Sep 17, 2024

Conversation

fj0r
Copy link
Contributor

@fj0r fj0r commented Sep 15, 2024

No description provided.

@fdncred fdncred closed this Sep 16, 2024
@fj0r
Copy link
Contributor Author

fj0r commented Sep 17, 2024

@fdncred I'm just a bit curious: As a manager, what role do other users play in your perspective?

this issue arose due to an update to the nushell version, and personally, if I want to avoid disrupting my existing workflow, I have to update it. However, submitting these updates takes additional time.

Of course, no one is forcing me, that's not my point. So, how do you view users who happen to be using this piece of code? I recall a previous instance when I attempted to update the git module, and you rejected it on the grounds that it might disrupt users' workflows, leading me to rename it to git-v2. To reiterate, I'm not interested in anything else.

update: your response is not a significant issue, and in fact, I have been trying my best to
act according to your requirements. Perhaps due to a lack of communication, some friction was inevitable. Given the current situation, it's pointless to discuss other matters; you and I have
already spent too much time on this. However, I'm curious about the strategy you employ regarding the interruption of potential users' workflow.

@fj0r
Copy link
Contributor Author

fj0r commented Sep 17, 2024

@fdncred You often mention the new repo, but is it possible that once users find a solution in one place, they might not actively seek out alternative solutions?

I understand that sometimes my approach might not be reasonable – the fundamental issue lies in the vague positioning of this repository – but your approach seems equally unreasonable to me.
Frankly, if there weren't any special reasons, I would indeed be reluctant to submit a PR here, as you've mentioned, because it involves dealing with you.
However, due to obvious special reasons, I have restrained myself from acting on that reluctance.
Yet, you have not.

@fj0r fj0r mentioned this pull request Sep 17, 2024
@fj0r
Copy link
Contributor Author

fj0r commented Sep 17, 2024

@fdncred In comparison, I've also reviewed others' PR and found no significant differences. If there were a well-functioning plugin marketplace and discovery mechanism in place, this repository wouldn't really be necessary, would it? Of course, that takes time – this repository should serve as a buffer in the meantime. In that sense, the purpose of this repository is to facilitate swift distribution (it will eventually become redundant if package managers and plugin markets mature). Indeed, when I was making rapid submissions earlier, I took this into account; there wasn't a reliable way to notify users of updates (with so many features intertwined), hence the urgency to update before users interact with them (It's not what you might think, treating it as my own repo. If it were my own repo, there would at least be two branches, which is straightforward and the intention is clear.). The awesome nu you mentioned is indeed another solution, but it's challenging to ascertain which contributions meet the criteria, especially since those criteria might be evolving(once there was a major adjustment to the directory structure, and I had to make many changes because of it.). Regarding the modules already present here, perhaps my understanding is flawed. I assumed Nushell needed a variety of modules to enrich its ecosystem – though it seems quite functional even without extensions – should anyone be updating them to at least syntactically correct standards?

Don't worry, I'm not really intending to continue submitting, I just want to understand where I went wrong.

@fdncred
Copy link
Collaborator

fdncred commented Sep 17, 2024

It's truly unfortunate. I don't wish to discourage users submitting code to nu_scripts. However, since I land 99.9% of everything on the nu_scripts repo I have a good perspective of how people use the repo.

In general, people either submit new scripts or they update older ones for version compatibility. That's about it. There are other PRs, of course, but those two things make up the majority of the PRs. You, on the other hand, have sent in dozens of PRs with refactoring changes over and over again as if this were your personal repo. I have encouraged you many times in the past to not treat this repo as your own personal repo. I once thought that your code would eventually land at some stability state, so I kept landing your PRs even when others told me you were not using our repo correctly. Unfortunately, that never happened so I quit landing your PRs. If you want to remove your code from this repo, I'd accept that PR.

I've offered to link to your nushell scripting repo so others can find your code. I'd still be happy to do that in nu_scripts or in awesome-nu. You could just have a folder with your github name and a readme.md with a link and description. If you want to discuss this further, please come to our discord.

@nushell nushell locked as too heated and limited conversation to collaborators Sep 17, 2024
@fdncred fdncred reopened this Sep 17, 2024
@fdncred fdncred merged commit 874918f into nushell:main Sep 17, 2024
1 check passed
@fdncred
Copy link
Collaborator

fdncred commented Sep 17, 2024

I think this change was due to a nushell change. There should've been a description that described what was happening but let's land this anyway. It remains to be seen whether all this code will remain on nu_scripts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants