Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues related to quoting #955

Closed
wants to merge 1 commit into from
Closed

Conversation

fj0r
Copy link
Contributor

@fj0r fj0r commented Sep 15, 2024

  • Fix issues related to quoting
  • Allow filtering of records related to the current session.

Allow filtering of records related to the current session.
@fdncred fdncred closed this Sep 16, 2024
@fj0r
Copy link
Contributor Author

fj0r commented Sep 17, 2024

@fdncred
For me, using Discord is inconvenient and I dislike instant messaging because it often consumes
more energy than I anticipate. Moreover, I don't see anything about this that can't be discussed
publicly. So, sorry, I'm clarifying here (my behavior might have been inappropriate, but I also
believe it inappropriate to prohibit replies; I understand you disagree with my viewpoint, but I don't understand why you would infringe upon my right to express it. Even though you offered Discord as an option, if I were amenable to using Discord, would I need you to remind me? Since GitHub has this functionality, I don't see it as a hindrance).

Please carefully review this modification https://github.com/nushell/nu_scripts/pull/953/files . The specifics are hazy now, but I recall after a certain nushell version upgrade, some things suddenly stopped working, perhaps the way upper bounds of ranges were defined changed? This update only modifies that part, and among other updates this time, there are also some related to this issue. My method of updating involves moving files to update the repository's content, which may not be ideal, but despite not being dedicated solely to nu_script, I do try to improve (previously, such fixes were part of a large PR; considering it was troublesome for you to review, this time they're split into multiple PRs by module). Indeed, in the past, I did engage in the "dozens of PRs" behavior you mentioned, but I believe I've since improved, even if not to your satisfaction.

Overall, I admit I can be a jerk; let's move on to the next point—can a villain like me do a tiny bit of good, like fixing the range syntax that was previously broken? Of course, it's likely no one uses this feature (by the way, I also brought in 4-5 nushell users), but at least it's not a bad thing, right?

And this update actually just adds one character, leading me to believe you haven't examined the actual content of this update. "talk is cheap, show me the code"?

There are more PRs this time, but that's the result of accumulated work due to my workflow. If considering one maintainer per module, why can't you view them as submissions from many different users? (I didn't do this because it's overly cumbersome, which I hope you can understand).

Alright, I've said too much nonsense, which goes against my principles. Let's stick to the matter at hand:

  • Please take a look at the update mentioned in the link above; it merely repairs the damage caused by the nushell upgrade. I'm not very familiar with Nushell, but I believe this falls under "updating older ones for version compatibility", Do you agree?
  • Do users who have used this code, if any, have the right to receive this update?
    • I know a new repository could be created or it could be added to awesome nu, but suppose users aren't aware that part of this repository's content will be updated via awesome nu.
    • On the other hand, creating a new repository requires elaborate rituals, much like chanting incantations to cast a spell, and what attracts me more to nushell is its casual nature—you might just execute a command casually and after a few modifications, unknowingly start a new project.(Of course, this is not an excuse, just the situation I encountered.)
  • I will consider migrating to Awesome Nu. The updates in the linked above don't require your acceptance either; it's just that this situation goes beyond my understanding, and I need to clarify it.
    • I can even refrain from updating related content in the future, and if you insist, I can consider abandoning the use of nushell, regardless of whether you have the right to demand so. After all, this is not the end of the world, and even if it were, it wouldn't prevent us from reaching a conclusion on this matter.

I acknowledge that the related issues stem from me; let's not debate that further. I just want answers to the questions above. You can respond, and of course, you're free to lock the thread if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants