-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: install Nushell from latest nightly build #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtoine
force-pushed
the
ci-use-nightly-build
branch
from
October 12, 2023 08:38
223b567
to
194d24d
Compare
amtoine
force-pushed
the
ci-use-nightly-build
branch
2 times, most recently
from
October 12, 2023 09:35
bd320f4
to
6bd87bc
Compare
amtoine
force-pushed
the
ci-use-nightly-build
branch
from
October 12, 2023 09:46
9e03c26
to
4bd9b0c
Compare
amtoine
changed the title
get the latest build with jq and extract the tarball
CI: install Nushell from latest nightly build
Oct 12, 2023
amtoine
force-pushed
the
ci-use-nightly-build
branch
from
October 12, 2023 13:38
904eede
to
2f186ec
Compare
amtoine
force-pushed
the
ci-use-nightly-build
branch
from
October 12, 2023 14:51
5f1ab19
to
b582c75
Compare
amtoine
force-pushed
the
ci-use-nightly-build
branch
from
October 12, 2023 14:53
b582c75
to
b28d6a5
Compare
ok, enough with the back and forth 👀 😉 😆 |
wow, 7 minutes to 10 seconds. That's a huge difference. |
pretty nice, right? 😏 it's just so much better to reuse the compilation from Nightly 💪 👌 |
melMass
pushed a commit
to amtoine/nu-git-manager
that referenced
this pull request
Oct 19, 2023
related to - nushell/nupm#30 - #24 wait for these to land - nushell/nupm#30 ## description this PR - adds an empty `tests/mod.nu` module so that `nupm test` can work - adds a CI greatly inspired by nushell/nupm#30 - does not need the `CWD` trick for Windows (:pray:) - pulls down Nushell from nightly builds - clones Nupm - shows the version of Nushell - runs the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
should close #29
Description
this PR uses the nightly builds of Nushell to save download + compilation time. The CI goes
from
main
branch)Changelog
this PR uses
$nu.current-exe
instead of implicitenu
innupm install
andnupm test
: this allows to not rely onnu
being in thePATH
, e.g. inside$HOME/
in the CIthe CI
curl
andjq
$HOME/nu