Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document custom completion options and styling #1726

Merged
merged 10 commits into from
Jan 1, 2025

Conversation

ysthakur
Copy link
Member

@ysthakur ysthakur commented Dec 30, 2024

Document the fact that custom completers can return a record with an options field, as well as the fact that each individual suggestion can include a style, for changing the color of that suggestion.

Closes #1670

Thank you to rose and NotTheDr01ds for getting ansi highlighting working. Sadly, I only ended up using it for a single code block, but here's to many more ansi blocks in the future!

Copy link
Collaborator

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ysthakur ysthakur merged commit 755d7a8 into nushell:main Jan 1, 2025
2 checks passed
@ysthakur ysthakur deleted the completer-record-return branch January 1, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

record-return from custom command completers
2 participants