Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: add highlights query #6

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Apr 27, 2023

Related to #5.

@1Kinoti i really wanted to have the hightlights for neovim so i took the ones from your fork and made these PR 😇

changes

Note
extra details in the commit bodies

  • e579d5b: get the raw file from @1Kinoti's fork
  • fa9607c: format the file a bit.
    i do not know a lot about the syntax but i went with 4 spaces and, i hope, a consistent format across the file 😌

@amtoine amtoine added the enhancement New feature or request label Apr 27, 2023
@amtoine amtoine self-assigned this Apr 27, 2023
@1Kinoti
Copy link
Contributor

1Kinoti commented Apr 27, 2023

did you test it out to make sure the syntax highlighting works?

@amtoine
Copy link
Member Author

amtoine commented Apr 28, 2023

did you test it out to make sure the syntax highlighting works?

yes i did and i think it looks great, at least a looooot better than just a wall of white text 😮

nu-treesitte

@1Kinoti
Copy link
Contributor

1Kinoti commented Apr 28, 2023

that looks gooood!

@amtoine
Copy link
Member Author

amtoine commented Apr 28, 2023

that looks gooood!

yeeeeah 🤩

and the goal of this really is to have a base to build upong 😋

@fdncred
Copy link
Collaborator

fdncred commented Apr 28, 2023

Nice. Thanks for the screenshot. Let's keep on chugging.

@fdncred fdncred merged commit 76a91ec into nushell:main Apr 28, 2023
@amtoine amtoine deleted the feature/add-highlights-query branch April 28, 2023 14:08
mrdgo pushed a commit to mrdgo/tree-sitter-nu that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants