fix a11y

nuxeo · Jan 15, 2024 · ed05d8a · ed05d8a
1 parent 5d23424
commit ed05d8a
Show file tree

Hide file tree

Showing 22 changed files with 32 additions and 58 deletions.
diff --git a/.github/workflows/a11y.yaml b/.github/workflows/a11y.yaml
@@ -35,7 +35,7 @@ jobs:
       with:
         ref: ${{ env.BRANCH_NAME }}
 
-      - run: git config user.name "nuxeo-webui-jx-bot" && git config user.email "[email protected]"
+    - run: git config user.name "nuxeo-webui-jx-bot" && git config user.email "[email protected]"
 
     - uses: actions/setup-node@v3
       with:

diff --git a/.github/workflows/catalog.yaml b/.github/workflows/catalog.yaml
@@ -79,9 +79,6 @@ jobs:
       - name: Install libxml2-utils (xmllint)
         run: sudo apt-get update && sudo apt-get install -y libxml2-utils
 
-      - name: Install libxml2-utils (xmllint)
-        run: sudo apt-get update && sudo apt-get install -y libxml2-utils
-
       - name: Setup parameters (release)
         if: github.event_name == 'release'
         working-directory: packages/nuxeo-designer-catalog

diff --git a/.github/workflows/cross-repo.yaml b/.github/workflows/cross-repo.yaml
@@ -192,14 +192,10 @@ jobs:
           fi
           mvn install -ntp $active_profiles -DskipInstall
 
-      #==================================================================================================================
-      # this line of code has been commented on due to some driver issues, we will resume it once WEBUI-1266 is resolved.
-      #==================================================================================================================
-      # - name: A11y checks
-      #   if: ${{ github.event.inputs.skip_a11y == 'false' }}
-      #   run: |
-      #     mvn -B -nsu -f plugin/a11y -ntp install
-      #==================================================================================================================
+      - name: A11y checks
+        if: ${{ github.event.inputs.skip_a11y == 'false' }}
+        run: |
+          mvn -B -nsu -f plugin/a11y -ntp install
 
       - name: Archive cucumber reports
         if: ${{ always() }}

diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -63,11 +63,6 @@ jobs:
           echo "BRANCH_NAME=${GITHUB_HEAD_REF##*/}" >> $GITHUB_ENV
           echo "PACKAGE_VERSION=$(npx -c 'echo "$npm_package_version"')" >> $GITHUB_ENV
 
-      - name: Prepare environment
-        run: |
-          echo "BRANCH_NAME=${GITHUB_HEAD_REF##*/}" >> $GITHUB_ENV
-          echo "PACKAGE_VERSION=$(npx -c 'echo "$npm_package_version"')" >> $GITHUB_ENV
-
       - name: Get prerelease version
         run: |
           git fetch origin --tags
@@ -107,11 +102,17 @@ jobs:
           mvn -B -nsu -ntp -f plugin/itests/addon install
           mvn -B -nsu -ntp -f plugin/itests/marketplace install
 
-      - name: Nuxeo package build
+      - name: 'Update settings.xml with server configuration'
         run: |
-          mvn -ntp install -DskipInstall
-          mvn -B -nsu -ntp -f plugin/itests/addon install
-          mvn -B -nsu -ntp -f plugin/itests/marketplace install
+          echo '<settings>
+              <servers>
+                <server>
+                  <id>maven-internal</id>
+                  <username>${{ secrets.PACKAGES_AUTH_USER }}</username>
+                  <password>${{ secrets.PACKAGES_AUTH_TOKEN }}</password>
+                </server>
+              </servers>
+              </settings>' > ~/.m2/settings.xml
 
       - name: Archive packages
         uses: actions/upload-artifact@v2

diff --git a/.github/workflows/veracode.yml b/.github/workflows/veracode.yml
@@ -190,5 +190,4 @@ jobs:
       with:
         token: ${{ secrets.SLACK_BOT_TOKEN }}
         path: results.txt
-        channel: ${{ secrets.SLACK_CHANNEL_ID }}
-
+        channel: ${{ secrets.SLACK_CHANNEL_ID }}
diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rest/directory.js b/addons/nuxeo-spreadsheet/app/nuxeo/rest/directory.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rest/query.js b/addons/nuxeo-spreadsheet/app/nuxeo/rest/query.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rest/request.js b/addons/nuxeo-spreadsheet/app/nuxeo/rest/request.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rpc/directory.js b/addons/nuxeo-spreadsheet/app/nuxeo/rpc/directory.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rpc/operation.js b/addons/nuxeo-spreadsheet/app/nuxeo/rpc/operation.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rpc/query.js b/addons/nuxeo-spreadsheet/app/nuxeo/rpc/query.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/widget.js b/addons/nuxeo-spreadsheet/app/nuxeo/widget.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/ui/column.js b/addons/nuxeo-spreadsheet/app/ui/column.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/directory.js b/addons/nuxeo-spreadsheet/app/ui/editors/directory.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/document.js b/addons/nuxeo-spreadsheet/app/ui/editors/document.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/image.js b/addons/nuxeo-spreadsheet/app/ui/editors/image.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/select2.js b/addons/nuxeo-spreadsheet/app/ui/editors/select2.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/user.js b/addons/nuxeo-spreadsheet/app/ui/editors/user.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/ui/log.js b/addons/nuxeo-spreadsheet/app/ui/log.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/ui/spreadsheet.js b/addons/nuxeo-spreadsheet/app/ui/spreadsheet.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/addons/nuxeo-spreadsheet/app/ui/widgets.js b/addons/nuxeo-spreadsheet/app/ui/widgets.js
@@ -1,5 +1,5 @@
 /*
- * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
+ *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. 
 All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
  *
  * All rights reserved. This program and the accompanying materials

diff --git a/test/nuxeo-picture-formats.test.js b/test/nuxeo-picture-formats.test.js
@@ -97,23 +97,4 @@ suite('nuxeo-picture-formats', () => {
       expect(element._getDownloadUrl()).to.equal('');
     });
   });
-
-  suite('fetch download url', () => {
-    test('Should fetch download url when item has downloadUrl property', () => {
-      const item = {
-        downloadUrl: 'abc.docx?changeToken=1-0&clientReason=download',
-      };
-      expect(element._getDownloadUrl(item)).to.equal('abc.docx?changeToken=1-0&clientReason=download');
-    });
-
-    test('Should fetch download url when item does not have downloadUrl property', () => {
-      const item = {
-        data: 'abc.docx?changeToken=1-0',
-      };
-      expect(element._getDownloadUrl(item)).to.equal('abc.docx?changeToken=1-0');
-    });
-    test('Should not fetch download url when input is not provided', () => {
-      expect(element._getDownloadUrl()).to.equal('');
-    });
-  });
 });