Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEBUI-1355: disable unit tests using for firefox #2019

Merged
merged 1 commit into from
Nov 22, 2023
Merged

WEBUI-1355: disable unit tests using for firefox #2019

merged 1 commit into from
Nov 22, 2023

Conversation

rakeshkumar1019
Copy link
Collaborator

@rakeshkumar1019 rakeshkumar1019 commented Nov 17, 2023 •
edited
Loading

@rakeshkumar1019 rakeshkumar1019 requested a review from a team as a code owner November 17, 2023 04:44
swarnadipa-dev
swarnadipa-dev previously approved these changes Nov 20, 2023
View reviewed changes
rahuljain-dev
rahuljain-dev previously approved these changes Nov 20, 2023
View reviewed changes
@rahuljain-dev
Copy link
Contributor

@rakeshkumar1019 please add ticket reference/comment when we will revert this action

@rakeshkumar1019
Copy link
Collaborator Author

@rakeshkumar1019 please add ticket reference/comment when we will revert this action

added

poonamyadav252
poonamyadav252 previously requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@poonamyadav252 poonamyadav252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly add a comment on top of the commented code (e.g. why we commented on the code and when we will fix it)and wrap it under a single-line comment.

@rakeshkumar1019 rakeshkumar1019 force-pushed the task-WEBUI-1355-disable-unit-tests-using-for-firefox-3.0.x branch from 591c9a9 to 843c885 Compare November 20, 2023 08:44
@rakeshkumar1019
Copy link
Collaborator Author

Kindly add a comment on top of the commented code (e.g. why we commented on the code and when we will fix it)and wrap it under a single-line comment.

added

@rakeshkumar1019 rakeshkumar1019 dismissed poonamyadav252’s stale review November 20, 2023 10:08

made changes as requested

rahuljain-dev
rahuljain-dev previously approved these changes Nov 20, 2023
View reviewed changes
@swarnadipa-dev swarnadipa-dev self-requested a review November 20, 2023 10:25
swarnadipa-dev
swarnadipa-dev previously approved these changes Nov 20, 2023
View reviewed changes
@rakeshkumar1019 rakeshkumar1019 force-pushed the task-WEBUI-1355-disable-unit-tests-using-for-firefox-3.0.x branch from 843c885 to 6ed29ef Compare November 21, 2023 05:41
@rahuljain-dev rahuljain-dev self-requested a review November 21, 2023 11:53
@rakeshkumar1019 rakeshkumar1019 removed the request for review from swarnadipa-dev November 21, 2023 11:59
@rakeshkumar1019 rakeshkumar1019 merged commit 1f2933c into maintenance-3.1.x Nov 22, 2023
@rakeshkumar1019 rakeshkumar1019 deleted the task-WEBUI-1355-disable-unit-tests-using-for-firefox-3.0.x branch November 22, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arupmmi07 arupmmi07 arupmmi07 approved these changes

@poonamyadav252 poonamyadav252 poonamyadav252 approved these changes

@Nishant0928 Nishant0928 Nishant0928 approved these changes

@rahuljain-dev rahuljain-dev rahuljain-dev approved these changes

@swarnadipa-dev swarnadipa-dev Awaiting requested review from swarnadipa-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rakeshkumar1019 @rahuljain-dev @arupmmi07 @swarnadipa-dev @poonamyadav252 @Nishant0928