feat: auto enable experimental.processCSSVariables for tailwindcss v4
#506
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 80.13% 80.59% +0.46%
==========================================
Files 13 13
Lines 1067 1072 +5
Branches 282 293 +11
==========================================
+ Hits 855 864 +9
+ Misses 205 200 -5
- Partials 7 8 +1 ☔ View full report in Codecov by Sentry. |
| @@ -129,6 +129,13 @@ export default defineNuxtModule<ModuleOptions>({ | |||
| } | |||
| } | |||
|
|
|||
| // Set `options.experimental.processCSSVariables` to `true` if TailwindCSS V4 is installed (which requires @tailwindcss/vite or @tailwindcss/postcss) | |||
| if (await findPath(await resolvePath('@tailwindcss/vite')) || await findPath(await resolvePath('@tailwindcss/postcss'))) { | |||
There was a problem hiding this comment.
my only question is the potential perf cost of these resolutions - should we instead make a PR to the nuxt tailwind module enable the flag?
There was a problem hiding this comment.
The module still doesn't support v4 as there is an issue open where we were discussing how necessary it would be and which features should be kept now that v4 handles some of the features the module was tackling.
Relevant issues are nuxt-modules/tailwindcss#820 and nuxt-modules/tailwindcss#919
There was a problem hiding this comment.
This would definitely be the most performant method but iirc the module hasn't supported tailwind v4 yet.
There was a problem hiding this comment.
Or maybe, we could hook into prepare:types so the resolutions will only need to be ran once every time nuxt prepare is executed. I'll look into that later.
|
Marked as draft in favor of #515 |
🔗 Linked issue
Closes #468.
❓ Type of change
📚 Description
Also enables test for Tailwind v4