Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): improve Traditional Chinese translation #3051

Merged
merged 4 commits into from
Jan 10, 2025
Merged

fix(locale): improve Traditional Chinese translation #3051

merged 4 commits into from
Jan 10, 2025

Conversation

ChiahongHong
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Correct mixed Simplified Chinese in Traditional Chinese translations
    • 体 changed to ι«”
    • δΈͺ changed to 個
    • 减 changed to ζΈ›
  • Adjust terminology to better align with usage in Taiwan
    • εŒΉι… changed to 相符
    • 剡建 changed to ε»Ίη«‹

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@ChiahongHong
fix(locale): improve Traditional Chinese translation
501ad2a 
- correct mixed Simplified Chinese in Traditional Chinese translations
  - `体` changed to `ι«”`
  - `δΈͺ` changed to `個`
  - `减` changed to `ζΈ›`
- adjust terminology to better align with usage in Taiwan
  - `εŒΉι…` changed to `相符`
  - `剡建` changed to `ε»Ίη«‹`
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 8, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@3051

commit: 4a7a00c

@benjamincanac benjamincanac requested a review from hywax January 8, 2025 16:03
@benjamincanac
Copy link
Member

@BlackWhite2000 Since you originally created this file, would you mind reviewing it? 😊

@hywax
Copy link
Collaborator

hywax commented Jan 8, 2025

@benjamincanac I don't speak Chinese. But gpt said it's okay. πŸ˜„

The words in the translation look correct and conform to the common usage of traditional Chinese (繁體中文). I've compared their meaning and usage in context, and they seem to match.

@ChiahongHong
Copy link
Contributor Author

The actual difference is a bit difficult to explain to someone unfamiliar with Chinese. To use an English analogy, it’s like the differences between British and American English in terms of spelling and word usage.

I hope @BlackWhite2000 can help confirm thisπŸ˜†

@benjamincanac Volta.net
Copy link
Member

@hywax Sorry I added you as reviewer because of latest commit history, I thought it was you who created the file for a second 😬

@benjamincanac
Copy link
Member

@ChiahongHong Would you mind fixing the conflicts? 😬

@ChiahongHong
Copy link
Contributor Author

@benjamincanac resolved!

@benjamincanac benjamincanac merged commit 5c2c55f into nuxt:v3 Jan 10, 2025
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hywax hywax hywax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChiahongHong @benjamincanac @hywax