Tag/name images with branch name #92
Conversation
To support building multiple branches in parallel, include the branch name, either as a tag or as part of the image name. Contributes to nv-gha-runners/roadmap#127
There was a problem hiding this comment.
Appreciate you working on this, @KyleFromNVIDIA. I left a few comments.
Here are some additional thoughts:
We'll need to update the main.yaml workflow so that it gets triggered to build/deploy images on branches other than main. I think we should use the test/* branch filter to ensure all test/ prefixed branches publish images
It'd also be good to add a small snippet about this in the README.
|
Oh, one more comment. Can you remove the runner version strings/tags from the publishes images/AMIs? I mentioned that briefly in https://github.com/nv-gha-runners/roadmap/issues/127. We will coordinate with @jjacobelli to ensure this change doesn't cause any breakages. |
gc/collectors/amis.py
Outdated
| amis = sorted( | ||
| amis, key=lambda x: parser.parse(x["CreationDate"]), reverse=True | ||
| ) | ||
| if img_name in self.current_images: | ||
| if branch_name in self.current_branches: |
There was a problem hiding this comment.
I'm not sure the logic here is correct.
Branches publish many AMIs. If we only save a single AMI from a current branch (as done in the next line), we'd discard many legitimate AMIs.
There was a problem hiding this comment.
I've given the GC logic another go based on our discussion. Please take a look.
To support building multiple branches in parallel, include the branch name, either as a tag or as part of the image name.
Contributes to https://github.com/nv-gha-runners/roadmap/issues/127