Support proto encoding for DASH_VNET_ROUTE #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Oct 20, 2022
| string underlay_ip = 8; | ||
| string overlay_sip = 9; | ||
| string overlay_dip = 10; | ||
| string metering_bucket = 11; |
There was a problem hiding this comment.
does this put a dependency on schema changes?
There was a problem hiding this comment.
Yes, you are right.
This PR is a POC, if we want to support protobuf encoding with sonic db schema, then we have to manually create proto definition.
And we can support protobuf encoding with sonic yang schema in the future, because ygot can translate yang models to proto format.
prsunny
reviewed
Nov 8, 2022
| Vnet string `protobuf:"bytes,5,opt,name=vnet,proto3" json:"vnet,omitempty"` | ||
| CustomerAddr string `protobuf:"bytes,6,opt,name=customer_addr,json=customerAddr,proto3" json:"customer_addr,omitempty"` | ||
| Appliance string `protobuf:"bytes,7,opt,name=appliance,proto3" json:"appliance,omitempty"` | ||
| UnderlayIp string `protobuf:"bytes,8,opt,name=underlay_ip,json=underlayIp,proto3" json:"underlay_ip,omitempty"` |
There was a problem hiding this comment.
Can this be IP address instead of string?
Yakiv-Huryk
pushed a commit
that referenced
this pull request
Oct 21, 2024
Why I did it Update telemetry container to support new gnmi config interface. How I did it Use new target to support mixed schema, and we can enable/disable telemetry and gnmi config interface. How to verify it Build target and run unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Json deserialization performance is poor, and DASH_VNET_ROUTE needs better performance.
How I did it
Update gnmi server and client to support proto encoding for DASH_VNET_ROUTE.
How to verify it
Run unit test.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)