Fixed tree-sitter-norg parser builds on MacOS. #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added use_makefile, which is how nvim-treesitter builds the norg parser by default and correctly adds the required flags - Removed a MacOS build kludge that is no longer needed (and seems not to work anymore) - Removed branch specification which is ignored when setting revision.
|
Hey I think you're changes are already covered in this PR |
|
#1020 is stalled though, I could see merging this in the meantime. |
|
FWIW, I got a clean build with this PR on an M3 MacBook running MacOS 15, and also on an x86_64 laptop running Linux Mint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on an Apple silicon machine running macOS 14.7, and an Intel machine running macOS running macOS 13.7.
Fixes nvim-neorg/tree-sitter-norg#45