-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org-attach feature #878
base: master
Are you sure you want to change the base?
Conversation
79fa58e
to
9148275
Compare
Hey! Thanks for the PR! To make things simpler, can we extract this into its own PR? |
Sure thing 👍 I'll mark this PR as a draft in the meantime, to keep things organized |
299f922
to
57ca4e8
Compare
71802a5
to
2ff76bd
Compare
@troiganto I merged the other PR and rebased this one to resolve conflicts. |
a19eeea
to
acbd71a
Compare
52fdf57
to
918a6a7
Compare
918a6a7
to
b0c578a
Compare
828c4b5
to
59df437
Compare
59df437
to
be9c79c
Compare
be9c79c
to
9e939aa
Compare
This reverts commit 272da8c217455f2fde59411f59e5e51ea44a3125.
9e939aa
to
73a070b
Compare
Hi, apologies for dropping such a large PR in your lap!
I've been working on-and-off on attachments and it's in a state now where I believe it works as intended and very similarly to the Emacs version. 🙂
The feature seemed simple., but ended up ballooning because:
orgmode.utils.fs.substitute_path
) for my use case.I've split commits up as much as I could to make accepting/rejecting each individual change easier. I've also split the implementation of org-attach into 6-7 commits to make it easier to review them.
To be clear, I don't expect all changes to go into the main repository. Let me know if there are any design decisions that you'd rather not commit to maintaining. 😉
Some of my more dubitable choices:
vim.uv.fs_*
functions in a moduleorgmode.attach.fs
. I simply couldn't figure out how to write an async recursive copy any other way.orgmode.attach.ui
. Some look weird because they replicate Emacs dialogs (yes_or_no_or_cancel_slow()
is the equivalent of yes-or-no-p) and might not necessarily make sense in nvim.orgmode.attach.core
and wrapped it inorgmode.attach
. This separation required passing around a few callbacks and effectively writing every function twice. It may be more work than it's worth.Thanks again for keeping this project going, it's been helping me a lot!