Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt to add larger scale ocean basins (derived from the marine_regions polygons). I basically just followed @nvkelso s instructions in #697 and that seems to work reasonably well.
I have so far only looked at the large scale ocean basins, and noticed one oddity:
In Addition to the regions I expected, there is a small strip (I belive along the West Coast of Africa) that has the name "None". I plotted the shape in geopandas
Any suggestions how to deal with this region? Does that need to be addressed in the 'marine_poly' source?
Once that is resolved, would the addition of the shapefiles be enough, or should I document exactly the steps I have taken to arrive there?
For posteriority this is what I did on my local machine:
Install Node.js(was already installed)npm install -g mapshaper
git clone my_fork_of_natural_earth
mapshaper -i 10m_physical/ne_10m_geography_marine_polys.shp -dissolve oceanbasin -o 10m_physical/ne_10m_oceanbasin.shp
mapshaper -i 10m_physical/ne_10m_geography_marine_polys.shp -dissolve subbasin copy-fields=oceanbasin -o 10m_physical/ne_10m_subbasin.s