Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocean basins and subbasins #783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbusecke
Copy link

This is my first attempt to add larger scale ocean basins (derived from the marine_regions polygons). I basically just followed @nvkelso s instructions in #697 and that seems to work reasonably well.

I have so far only looked at the large scale ocean basins, and noticed one oddity:
In Addition to the regions I expected, there is a small strip (I belive along the West Coast of Africa) that has the name "None". I plotted the shape in geopandas

import geopandas as gpd
basins = gpd.read_file('10m_physical/ne_10m_oceanbasin.shp')
basins.iloc[[11]].plot(figsize=[20,14])

image

Any suggestions how to deal with this region? Does that need to be addressed in the 'marine_poly' source?

Once that is resolved, would the addition of the shapefiles be enough, or should I document exactly the steps I have taken to arrive there?

For posteriority this is what I did on my local machine:

  1. Install Node.js (was already installed)
  2. npm install -g mapshaper
  3. git clone my_fork_of_natural_earth
  4. mapshaper -i 10m_physical/ne_10m_geography_marine_polys.shp -dissolve oceanbasin -o 10m_physical/ne_10m_oceanbasin.shp
  5. mapshaper -i 10m_physical/ne_10m_geography_marine_polys.shp -dissolve subbasin copy-fields=oceanbasin -o 10m_physical/ne_10m_subbasin.s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exploring the addition of 'Ocean Basin' regions
1 participant