remove obsolete and incorrect versions of TRPDRV #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffhammond Could you rebase this branch? |
ccsd_trpdrv_nb has a bug in it. all of the nonblocking stuff is in the OpenMP (_omp) version. that should be used instead. ccsd_trpdrv_bgp is obsolete. for any Blue Gene like system, the OpenMP version will be fine. Signed-off-by: Jeff Hammond <[email protected]>
jeffhammond
force-pushed
the
disable_ccsd_trpdrv_nb
branch
from
057c429
to
4ef2c61
Compare
|
rebase done |
Thanks. It might take me some time to go through this pull since the flang-new-20 action might fail and I still not have looked at this compiler issue (clearly orthogonal to the this changes) yet |
edoapra
approved these changes
Oct 4, 2024
|
Thanks for the code cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the former issue was found in the context of ARMCI nonblocking request handles, but i think it might have been observed before.