Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change arrow color, dynamic image size #113

Merged
merged 5 commits into from
Sep 18, 2021
Merged

change arrow color, dynamic image size #113

merged 5 commits into from
Sep 18, 2021

Conversation

dchen150
Copy link
Contributor

@dchen150 dchen150 commented Sep 16, 2021

Description

#55, #72. Arrow changed to primary color. Width is dynamic depending on viewport width and height.
image

Other considerations

@github-actions
Copy link

github-actions bot commented Sep 16, 2021

Visit the preview URL for this PR (updated for commit 603b18b):

https://nwplus-io--pr113-carouselnit-ghf6nmfu.web.app

(expires Sat, 25 Sep 2021 00:34:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@dchen150 dchen150 requested a review from kevin-zou September 16, 2021 10:02
@anneguo3
Copy link
Contributor

@dchen150 when I went to the staging PR it still only lets me navigate through the photos based on clicking the arrow exactly rather than just on the photo area

@kevin-zou
Copy link
Contributor

Does this show up for you locally? The diamonds look like they've seen better days :'(
image

If not it's probably just the deploy being weird again

@dchen150
Copy link
Contributor Author

@anneguo3 will work on it. @kevin-zou ya idk why it does that. When you expand it it goes back to regular diamonds. Do you think importing an SVG instead of making the diamonds out of css would be better? Or is it worth investing time in figuring out why the diamonds are doing that when the window shrinks

@kevin-zou
Copy link
Contributor

Oh I think I found out why. The width: 30% property on its container makes it distorted. Removing this seems to fix it - can you try this and see if it doesn't break anything?

Copy link
Contributor

@kevin-zou kevin-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anne's described behaviour on-click of the entire image changing the image isn't implemented yet, but everything else looks good to me 🔥

Comment on lines 46 to 47
width: 100%;
height: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set a static height like we did for the desktop view? On mobile the different heights between images leads to a "jumpy" experience whenever the picture changes!

Copy link
Contributor

@panjenny0 panjenny0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dchen150 dchen150 merged commit aae033d into main Sep 18, 2021
@dchen150 dchen150 deleted the carouselNit branch September 18, 2021 02:17
@anneguo3
Copy link
Contributor

@dchen150 i'm on a widescreen monitor and...
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants