-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change arrow color, dynamic image size #113
Conversation
Visit the preview URL for this PR (updated for commit 603b18b): https://nwplus-io--pr113-carouselnit-ghf6nmfu.web.app (expires Sat, 25 Sep 2021 00:34:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
@dchen150 when I went to the staging PR it still only lets me navigate through the photos based on clicking the arrow exactly rather than just on the photo area |
@anneguo3 will work on it. @kevin-zou ya idk why it does that. When you expand it it goes back to regular diamonds. Do you think importing an SVG instead of making the diamonds out of css would be better? Or is it worth investing time in figuring out why the diamonds are doing that when the window shrinks |
Oh I think I found out why. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anne's described behaviour on-click of the entire image changing the image isn't implemented yet, but everything else looks good to me 🔥
components/Carousel.js
Outdated
width: 100%; | ||
height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set a static height like we did for the desktop view? On mobile the different heights between images leads to a "jumpy" experience whenever the picture changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@dchen150 i'm on a widescreen monitor and... |
Description
#55, #72. Arrow changed to primary color. Width is dynamic depending on viewport width and height.

Other considerations