Bugfixes for v0.3 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this also fixes bug introduced by "26c2a53 lib: tool: export SJA1105T device id to the config file" where there was a mismatch between the variable name in the code (device_id) and the string in the conf file that the code was actually looking for (device-id). * although harmless, sja1105-tool was complaining that "device_id field not defined in config file, setting default value 0x9e00030e", and upon setting it, that "Invalid key device_id", because it was in fact looking for "device-id" Signed-off-by: Vladimir Oltean <[email protected]>
…t config * it is still unclear from the IP perspective what is the "correct" value to configure this register to, but smaller period seems to be better for keeping the TAS clock in sync with the system clock Signed-off-by: Vladimir Oltean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.