-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for dark theme #470
base: master
Are you sure you want to change the base?
Conversation
Nice! I'll give this a better look later. Some of the rows will require colors (hidden and deleted torrents which the normal users don't really get to see) and IMO some of the |
I was wondering if hidden torrents are hidden even for admin (I was assuming they aren't but still). When it comes to deleted torrents I see only 2 ways. Leave them as bright grey with dark font color or give them some different color. When it come to By the way I see quoteblock not looking for you as it should. Edit: I know why. Somewhere in the middle of checking I must have deleted it. |
I forgot to ask. Does hidden torrents have it's own class on torrent list or only in line style as in torrent view? Because I do have color theme for it already implemented in my style. I just don't know what I have to target. And how does it look in code? |
Here's the template line for the torrent CSS class: Here's the torrent page's class choosing: |
I see. Everything is clear now. I will make those today or tommorow. |
I will explain changes. Instead of making For deleted torrents I didn't use another pair of grey colors. Belive me you don't want grey rainbow you can go crazy looking at that. On the other hand I didn't want to use light grey to make bigger difference between them and not deleted because it's not how dark theme should look like. I spared you madness and made them blue. |
I was asked by Anna-Maria Meriniemi if I would like to make pull request with my DeepDark Nyaa.si style in stylish for official Nyaa repo. So here it is. I cleaned most of it from unnesesery code. I hope it's not too chaotic and noobish.