Fix regex matching in GetLengthOfNationalDestinationCode #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different to the regex in JAVA implementation.
phonenumbers_test.go
Outdated
| @@ -822,13 +822,13 @@ func TestGetLengthOfGeographicalAreaCode(t *testing.T) { | |||
| numName string | |||
| length int | |||
| }{ | |||
| {numName: "US_NUMBER", length: 3}, | |||
| {numName: "US_NUMBER", length: 1}, | |||
There was a problem hiding this comment.
isn't this wrong now... US area codes are 3 digits, UK are 2 etc
There was a problem hiding this comment.
Yes, that seems definitely wrong, let me investigate it and compare with the Java version
There was a problem hiding this comment.
Ok, found the issue comparing the whole method -reverted my unit test changes and updated the method to match the latest JAVA version of the library.
This reverts commit 12fc128.
rowanseymour
approved these changes
Nov 17, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 49.66% 49.66%
=======================================
Files 9 9
Lines 3304 3304
=======================================
Hits 1641 1641
Misses 1521 1521
Partials 142 142 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different to the regex in JAVA implementation.
Refer to issue #147