Some cleanup to topic crudl and ticket folders #5590
Merged
+66
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5590 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 551 551
Lines 25669 25654 -15
=========================================
- Hits 25669 25654 -15 ☔ View full report in Codecov by Sentry. |
norkans7
reviewed
Oct 28, 2024
| menu.add_modax( | ||
| _("Edit"), | ||
| "edit-topic", | ||
| f"{reverse('tickets.topic_update', args=[self.folder.topic.id])}", |
There was a problem hiding this comment.
Why use int ID instead of the UUID? I thought we were moving to use uuid in URLs as much as possible
There was a problem hiding this comment.
We've used UUIDs for things like flow editor as a way to let advanced users know the UUID for API operations. IMO there's no reason to use UUIDs everywhere.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.