Add Docker support #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
raynei86
commented
Aug 9, 2024
raynei86
commented
- Added docker and compose support
- Improved displaying of images uploaded with the new uploader.
The code was expecting an environment variable called `DATABASE_URL`, not the default `SQLALCHEMY_DATABASE_URI`.
Parsley could be used, but there is so much boilerplate for defining custom validators that it doesn't justify a one time use. Though this does mean a very intrusive and primitive alert dialog.
The scope of `blob_name` is inside the if statement, inaccessible to the `create_story()` call. This commit brings the variable to the same scope as the call.
It's a more appropriate location as they're related to stories, not the database.
This feature is too generic to be just inside the story view.
Seems risky to disable security. But it should be alright if it's only for development purposes.
Eliminates the callers need to check how an image is associated, or if an image is associated at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.