Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUST-1790: Make comment param in rsvp optional #529

Merged
merged 1 commit into from
Jan 16, 2024
Merged

CUST-1790: Make comment param in rsvp optional #529

merged 1 commit into from
Jan 16, 2024

Conversation

znseaman
Copy link
Contributor

@znseaman znseaman commented Jan 15, 2024

For CUST-1790, our POST /send-rsvp docs explicitly say that the comment param is optional. This PR changes the comment param to be optional.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e9d1a2) 91.79% compared to head (8d7d198) 91.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          62       62           
  Lines        2670     2670           
  Branches      490      490           
=======================================
  Hits         2451     2451           
  Misses        218      218           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SubashPradhan SubashPradhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

@znseaman znseaman merged commit a272086 into main Jan 16, 2024
4 checks passed
@mrashed-dev mrashed-dev deleted the CUST-1790 branch January 31, 2024 16:45
@mrashed-dev mrashed-dev mentioned this pull request Feb 9, 2024
mrashed-dev added a commit that referenced this pull request Feb 9, 2024
# Changelog
* Fix issue where Graph events were returning 400 on update (#524)
* Make comment param in rsvp optional (#529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants