fix: transform anyEmail array into comma-delimited any_email parameter in threads list #618
+55
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDDM
requested review from
pooja169usp,
wallacecs007,
krisgardiner and
kraju3
…r in threads list
AaronDDM
force-pushed
the
TW-3647-nylas-nodejs-fix-regression-in-google-event-search
branch
from
55b04e7 to
7f3964e
Compare
krisgardiner
approved these changes
Jan 22, 2025
Merged
AaronDDM
added a commit
that referenced
this pull request
Jan 23, 2025
…a-delimited any_email parameter in threads list #618
AaronDDM
added a commit
that referenced
this pull request
Jan 23, 2025
* Updated changelog * 7.7.3 * Updated change log to include fix: transform anyEmail array into comma-delimited any_email parameter in threads list #618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fixes #615 - looks like we introduced a regression in #606.
I've reverted that PR because the proper way to pass an array of items for a single query param is to repeat the query param.
Instead, I've added an override/transformation for the
threads.listmethod that converts theanyEmailquery param to a comma-separated list. I avoided putting this inapiClientbecause in my opinion, that's too disconnected from the resource where these overrides should occur.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.