Skip to content

Commit

Permalink
Just build from the latest version (#117)
Browse files Browse the repository at this point in the history
* remove kubectl version publishes

* remove GCLOUD_SDK_TAG arg

* update readme

* add codeowners

* keep GCLOUD_SDK_TAG in dockerfile

* set default tag

* fix paren
  • Loading branch information
tonglil authored Aug 26, 2019
1 parent 88679fc commit 6ac83b9
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 29 deletions.
28 changes: 4 additions & 24 deletions .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,39 +45,20 @@ pipeline:

publish_develop:
<<: *publish_config
build_args:
- GCLOUD_SDK_TAG=alpine
tag:
tags:
- "develop"
when:
event: push
branch: develop

publish_latest:
publish_release:
<<: *publish_config
build_args:
- GCLOUD_SDK_TAG=alpine
auto_tag: true

publish_1_10:
<<: *publish_config
build_args:
- GCLOUD_SDK_TAG=217.0.0-alpine
auto_tag: true
auto_tag_suffix: "k8s-1.10"

publish_1_11:
<<: *publish_config
build_args:
- GCLOUD_SDK_TAG=241.0.0-alpine
auto_tag: true
auto_tag_suffix: "k8s-1.11"

slack:
image: plugins/slack
channel: dv-notifications
secrets:
- slack_webhook
secrets: [slack_webhook]
when:
branch:
- develop
Expand All @@ -86,8 +67,7 @@ pipeline:
slack_tag:
image: plugins/slack
channel: dv-notifications
secrets:
- slack_webhook
secrets: [slack_webhook]
when:
event:
- tag
4 changes: 4 additions & 0 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# These owners will be the default owners for everything in the repo.
# Unless a later match takes precedence, these owners
# will be requested for review when someone opens a pull request.
* @nytm/delivery-engineering
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# see https://hub.docker.com/r/google/cloud-sdk/tags for available tags / versions
ARG GCLOUD_SDK_TAG
ARG GCLOUD_SDK_TAG=alpine

FROM google/cloud-sdk:${GCLOUD_SDK_TAG}

Expand Down
16 changes: 12 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,27 @@ Derive the API endpoints and credentials from the Google credentials and open th

### Tool

This tool follows [semantic versioning](https://semver.org/).

Use the `x.X` releases for stable use cases (eg 0.8).
Breaking changes may occur between `x.X` releases (eg 0.7 and 0.8), and will be documented in the [release notes](https://github.com/nytimes/drone-gke/releases).

### Kubernetes API

Use the release [tag](https://hub.docker.com/r/nytimes/drone-gke/tags/) suffixed with your desired `kubectl` version.
The last two-three minor releases are supported ([same as GKE](https://cloud.google.com/kubernetes-engine/versioning-and-upgrades)).
Since the [237.0.0 (2019-03-05) Google Cloud SDK][sdk], the container image contains multiple versions of `kubectl`.
The corresponding client version that matches the cluster version will be used automatically.
This follows the minor release support that [GKE offers](https://cloud.google.com/kubernetes-engine/versioning-and-upgrades).

If you want to use a different version, you can specify the version of `kubectl` used with the [`kubectl_version` parameter][version-parameter].

[sdk]: https://cloud.google.com/sdk/docs/release-notes#23700_2019-03-05
[version-parameter]: DOCS.md#kubectl_version

### Container

- Pushes to the [`develop`](https://github.com/nytimes/drone-gke/tree/develop) branch will update the image tagged `develop`.
- Pushes to the [`master`](https://github.com/nytimes/drone-gke/tree/master) branch will update the images tagged `latest` and corresponding `kubectl` versions.
- Tags to the [`master`](https://github.com/nytimes/drone-gke/tree/master) branch will create the images with the tag value (eg `0.7.1` and `0.7`) and corresponding `kubectl` versions.
- Pushes to the [`master`](https://github.com/nytimes/drone-gke/tree/master) branch will update the image tagged `latest`.
- Tags to the [`master`](https://github.com/nytimes/drone-gke/tree/master) branch will create the images with the patch and minor tag values (eg `0.7.1` and `0.7`).

## Usage

Expand Down

0 comments on commit 6ac83b9

Please sign in to comment.